-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UIBULKED-210: Improve user errors for invalid data - IncorrectTokenCountException error #476
Conversation
…untException error
@@ -210,7 +210,7 @@ export const BulkEditListFilters = ({ | |||
setIsFileUploaded(true); | |||
} catch ({ message }) { | |||
showCallout({ | |||
message: <FormattedMessage id="ui-bulk-edit.error.uploadedFile" />, | |||
message: <FormattedMessage id="ui-bulk-edit.error.incorrectFormatted" values={{ fileName:fileToUpload.name }} />, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be only when message contains IncorrectTokenCountException
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done!
@@ -21,7 +21,7 @@ import { | |||
JOB_STATUSES, | |||
TRANSLATION_SUFFIX, | |||
EDITING_STEPS, | |||
FILTERS, | |||
FILTERS, ERRORS, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
plz move to the next line - common codestyle
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
moved!
# Conflicts: # src/components/BulkEditList/BulkEditListFilters/BulkEditListFilters.js
Quality Gate passedIssues Measures |
https://folio-org.atlassian.net/browse/UIBULKED-210
Here made user friendly callout.
Screen.Recording.2024-02-12.at.15.53.08.mov